Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the bright limit to 5.2 in code and checklist #377

Merged
merged 3 commits into from
Oct 26, 2021
Merged

Move the bright limit to 5.2 in code and checklist #377

merged 3 commits into from
Oct 26, 2021

Conversation

jeanconn
Copy link
Contributor

@jeanconn jeanconn commented Sep 9, 2021 •
edited
Loading

Description

Move the bright limit warnings by 0.6 mags

Not sure how much we want to finesse the limits for the load review checklist and the starcheck warning (or just defer to the sparkles warning based on sigma)... or if we should just push them brighter by 0.6 mags.

Testing

  • there are no unit tests
  • Functional testing

For functional testing, I ran on the SEP2021B loads flight and test and confirmed the warnings on the 5.8 bright stars are no longer present.

1,2c1,2
<  ------------  Starcheck 13.12.0    -----------------
<  Run on Mon Oct 25 18:01:47 EDT 2021 by jeanconn from fido.cfa.harvard.edu
---
>  ------------  Starcheck 13.12.1.dev3+gdc48532    -----------------
>  Run on Mon Oct 25 18:10:53 EDT 2021 by jeanconn from fido.cfa.harvard.edu
49c49
< OBSID = 26134 at 2021:264:09:29:18.106   6.4 ACQ | 2.8 GUI | Critical: 5 Warn: 3 Caution: 7
---
> OBSID = 26134 at 2021:264:09:29:18.106   6.4 ACQ | 2.8 GUI | Critical: 4 Warn: 3 Caution: 7
62c62
< OBSID = 24300 at 2021:266:06:48:30.941   6.0 ACQ | 3.5 GUI | Critical: 5 Warn: 1 Caution: 6
---
> OBSID = 24300 at 2021:266:06:48:30.941   6.0 ACQ | 3.5 GUI | Critical: 4 Warn: 1 Caution: 6
66c66
< OBSID = 24303 at 2021:267:01:51:39.371   6.0 ACQ | 2.8 GUI | Critical: 5 Warn: 3 Caution: 6
---
> OBSID = 24303 at 2021:267:01:51:39.371   6.0 ACQ | 2.8 GUI | Critical: 4 Warn: 3 Caution: 6
243d242
< >> CRITICAL: [ 8] Magnitude. Guide star  5.836
732d730
< >> CRITICAL: [ 8] Magnitude. Guide star  5.836
845d842
< >> CRITICAL: [ 8] Magnitude. Guide star  5.836

@jeanconn jeanconn changed the title WIP Move the bright limit warnings by 0.6 mags WIP Move the bright limit to 5.2 in code and checklist Sep 28, 2021
@jeanconn jeanconn changed the title WIP Move the bright limit to 5.2 in code and checklist Move the bright limit to 5.2 in code and checklist Oct 13, 2021
@jeanconn
Copy link
Contributor Author

Checklist and change approved by SSAWG. Still needs note of functional test.

@jeanconn jeanconn merged commit efa5973 into master Oct 26, 2021
@jeanconn jeanconn deleted the bright-5p2 branch October 26, 2021 05:30
This was referenced Oct 26, 2021
Closed
Merged
@javierggt javierggt mentioned this pull request May 18, 2022
Closed
@javierggt javierggt mentioned this pull request Aug 3, 2022
Merged
This was referenced Jan 6, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taldcroft taldcroft taldcroft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeanconn @taldcroft